Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Conversation

@kadenzipfel
Copy link
Contributor

Closes: #124

Note: This isn't an ideal fix. It basically just assumes that if a token name and symbol can't be retrieved then that token is MKR. I've never actually seen any other token that doesn't use a regular string for its name and symbol, so I don't expect we'll run into this issue again. If anyone knows of a better way to do this, please feel free.

@TomAFrench
Copy link

This could be handled by having two copies of the ERC20 ABI (one for string, one for bytes32) and if the first reverts, then second can be used.

Example of this being in the Balancer subgraph: https://github.com/balancer-labs/balancer-subgraph/blob/818d705734f4393c88abbb587dd1c6bcfad4e66d/src/mappings/helpers.ts#L84-L108

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix indexing of the MKR token

2 participants