add separate option for disableProvideHover #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tm1000
approved these changes
Jan 29, 2024
|
This would be great please!!! |
|
Anyone able to merge/deploy this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I personally run other extensions that handle PHP method / property definitions for hover and autocomplete and while the extension currently has an option to disable the autocomplete it doesn't have one to disable the hover provider.
Looking at the psalm Language Server code I noticed that there was already a flag to disable the hover provider so I've added an option in the plugin to send that flag over when starting the Language Server.
The additions are made the same way that the 'Disable Auto Complete' option was passing along the
--enable-provide-hover=falseflag to the Language Server.