chore: document and test custom SSL Context passing #7044
+72
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tasssadar
commented
Oct 13, 2025
Comment on lines
+1054
to
+1056
| def cert_verify(self, *_args, **_kwargs) -> None: | ||
| # Override HTTPAdapter cert_verify method, it tries to load certs from disk otherwise | ||
| pass |
There was a problem hiding this comment.
This override was not necessary between (likely, not tested) 2.32.0 and 2.32.5, see #7040 , because the SSL context caching worked out that way.
Is it intended that it is required now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be the official, supported way of passing SSL context to Requests. Let's document and test it, so it does not break in the future.
It would be also fairly easy to modify
HTTPAdapterto actually take ssl context natively and make this easier for users - I can prepare a PR, but from the general vibe of the project, it seemed to me that expanding the feature set like this is not that desired, so just a test and docs for now.Fixes #7040