Fix test compatibility on Windows by using direct CA certificate path #7063
+5
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates
test_requests.pyto use the expired CA certificate path directly instead of relying on a symlink, improving cross-platform compatibility.Changes
tests/certs/valid/ca/ca.crtwithtests/certs/expired/ca/ca.crtin the testMotivation
The
tests/certs/valid/cadirectory is a symlink to../expired/ca, which doesn't work reliably on Windows without specific Git configuration for symlink support. This causes test failures on Windows environments.Technical Details
The valid server certificate is signed by the expired CA, so using the direct path
tests/certs/expired/ca/ca.crtis functionally correct and ensures consistent behavior across all platforms (Windows, macOS, and Linux).Testing