-
Notifications
You must be signed in to change notification settings - Fork 256
Document and announce ESC deletion protection feature #16334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
86ccd57 to
c1146cf
Compare
Review SummaryThis PR adds documentation and a blog post for the ESC deletion protection feature. The content is well-structured and mostly follows the style guide, but there are several issues that need to be addressed before merging. Critical IssuesMissing more break in blog postFile: content/blog/esc-deletion-protection/index.md:17 The blog post is missing the more break after the first paragraph. According to BLOGGING.md, this is required to control what appears on the blog home page. Add this HTML comment after line 15. Style Issues1. Improper heading capitalization in blog postFile: content/blog/esc-deletion-protection/index.md According to STYLE-GUIDE.md, H2 and deeper headings should use sentence case, not title case. Line 21: Change to "How it works" 2. Improper heading capitalization in documentationFile: content/docs/esc/administration/deletion-protection.md Multiple headings use title case instead of sentence case: Line 14: "Enabling deletion protection" 3. Missing blank line before headingFile: content/blog/esc-deletion-protection/index.md:30 According to STYLE-GUIDE.md, headings should be surrounded by blank lines. Add a blank line before line 30. 4. Navigation terminologyFile: content/blog/esc-deletion-protection/index.md:28 According to STYLE-GUIDE.md, use "navigate" not "navigate to". Change: "In the Pulumi Cloud console, navigate to your environment's settings" Content Suggestions
Positive Observations
Checklist Before Merge
Mention @claude if you would like me to review again after making changes or if you need help with any of these suggestions. |
Document and announce ESC deletion protection feature Adds documentation for the deletion protection feature in Pulumi ESC and a blog post announcing its availability. The deletion protection feature prevents accidental deletion of environments by requiring that protection be explicitly disabled before deletion. This helps safeguard production environments and shared configuration. Changes: - Add deletion protection documentation page in administration section - Update administration index to include deletion protection - Create blog post announcing the feature
c1146cf to
1792e40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the process here? Do we get a new image for this, or is this one OK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yikes. I didn't even know this was there.
Did this come from the blog template? Maybe we should ask the marketing folk to make us one for blogs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I'm fine with running with this one for the moment, since I'm sure we have a bunch of blog posts using it.
|
Your site preview for commit 1792e40 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16334-1792e40f.s3-website.us-west-2.amazonaws.com. |
|
Your site preview for commit e9767dd is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16334-e9767dda.s3-website.us-west-2.amazonaws.com. |
Proposed changes
Adds documentation for the deletion protection feature in Pulumi ESC and a blog post announcing its availability.
The deletion protection feature prevents accidental deletion of environments by requiring that protection be explicitly disabled before deletion. This helps safeguard production environments and shared configuration.
Changes:
Related issues (optional)
Fixes: https://github.com/pulumi/pulumi-service/issues/33815