Skip to content

Conversation

@bpellin
Copy link

@bpellin bpellin commented Mar 30, 2012

I cherry picked in a small fix from newer versions of less that is required in order to run on the Samsung browser. XmlHttpRequests to file:// URIs return a status of 200 on this browser, but version 1.1.4 of less assumes that only a status of 0 means success.

@putermancer
Copy link
Owner

Do you foresee any problems if I just update to the latest version? I
don't think it will break anything on my end and if it works for you
I'll probably just do that.

Ben Loveridge

On Mar 30, 2012, at 10:57 AM, bpellin
[email protected]
wrote:

I cherry picked in a small fix from newer versions of less that is required in order to run on the Samsung browser. XmlHttpRequests to file:// URIs return a status of 200 on this browser, but version 1.1.4 of less assumes that only a status of 0 means success.

You can merge this Pull Request by running:

git pull https://github.com/bpellin/less.js master

Or you can view, comment on it, or merge it online at:

#1

-- Commit Summary --

  • Accept 2xx statuses even for file requests
  • (dist) build 1.1.4

-- File Changes --

M dist/less-1.1.4.js (2)
M dist/less-1.1.4.min.js (4)
M lib/less/browser.js (2)

-- Patch Links --

https://github.com/bloveridge/less.js/pull/1.patch
https://github.com/bloveridge/less.js/pull/1.diff


Reply to this email directly or view it on GitHub:
#1

@bpellin
Copy link
Author

bpellin commented Mar 30, 2012

I haven't tested it, but I also don't forsee any problems.

-Brian
On Mar 30, 2012 5:10 PM, "Ben Loveridge" <
[email protected]>
wrote:

Do you foresee any problems if I just update to the latest version? I
don't think it will break anything on my end and if it works for you
I'll probably just do that.

Ben Loveridge

On Mar 30, 2012, at 10:57 AM, bpellin
[email protected]
wrote:

I cherry picked in a small fix from newer versions of less that is
required in order to run on the Samsung browser. XmlHttpRequests to file://
URIs return a status of 200 on this browser, but version 1.1.4 of less
assumes that only a status of 0 means success.

You can merge this Pull Request by running:

git pull https://github.com/bpellin/less.js master

Or you can view, comment on it, or merge it online at:

#1

-- Commit Summary --

  • Accept 2xx statuses even for file requests
  • (dist) build 1.1.4

-- File Changes --

M dist/less-1.1.4.js (2)
M dist/less-1.1.4.min.js (4)
M lib/less/browser.js (2)

-- Patch Links --

https://github.com/bloveridge/less.js/pull/1.patch
https://github.com/bloveridge/less.js/pull/1.diff


Reply to this email directly or view it on GitHub:
#1


Reply to this email directly or view it on GitHub:
#1 (comment)

@putermancer
Copy link
Owner

I've upgraded my fork to 1.3.0. Please try out master and see if it works for you and if a pull request is still necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants