Skip to content

Conversation

@mberz
Copy link
Member

@mberz mberz commented Nov 14, 2025

Which issue(s) are closed by this pull request?

Closes #215, #211, #183, #223

Changes proposed in this pull request:

Todo

Note

  • In comparison to the current baseline figures for balloon plots the default for the colormap encoding has changed from old parametrization phase=False to cmap_encoding='phase'

@mberz mberz added the enhancement New feature or request label Nov 14, 2025
@mberz mberz closed this Nov 14, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Done in Weekly Planning Nov 14, 2025
@mberz mberz reopened this Nov 14, 2025
@github-project-automation github-project-automation bot moved this from Done to Backlog in Weekly Planning Nov 14, 2025
@hoyer-a hoyer-a added this to the v1.0.0 milestone Nov 14, 2025
@hoyer-a hoyer-a self-assigned this Nov 14, 2025
@hoyer-a hoyer-a moved this from Backlog to Implementation in progress in Weekly Planning Nov 14, 2025
@hoyer-a hoyer-a force-pushed the refactor/collect_cb_changes branch from 8311b1e to cd4c63a Compare January 9, 2026 11:02
* add style parameter to plot module, tests and baseline plots
* import context as pyfar_plot_context
hoyer-a and others added 10 commits January 15, 2026 13:08
Co-authored-by: Fabian Brinkmann <fabian.brinkmann@mailbox.org>
Co-authored-by: Fabian Brinkmann <fabian.brinkmann@mailbox.org>
Plots/Add general guide on the overlap issue
use dipole in y-direction instead of x-direction
@hoyer-a hoyer-a moved this from Implementation in progress to Require review in Weekly Planning Jan 21, 2026
@hoyer-a hoyer-a marked this pull request as ready for review January 21, 2026 11:49
@mberz
Copy link
Member Author

mberz commented Jan 22, 2026

Thanks @hoyer-a, I did a quick review of the changes but cannot submit it since I've opened the original PR.
Since all changes have been reviewed individually I'd suggest to not do in-depth reviews anymore at this point.
If that's alright, I'll merge the PR later today.

@mberz mberz merged commit 4eb13c6 into develop Jan 22, 2026
4 of 7 checks passed
@github-project-automation github-project-automation bot moved this from Require review to Done in Weekly Planning Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants