Hot: gaussian sampling fails for certain higher sh orders #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahms5
requested review from
a team,
f-brinkmann,
hoyer-a,
mberz,
sikersten and
tluebeck
hoyer-a
approved these changes
Jan 17, 2026
github-project-automation
bot
moved this from Require review
to Reviewer Approved
in Weekly Planning
f-brinkmann
approved these changes
Jan 19, 2026
mberz
approved these changes
Jan 21, 2026
github-project-automation
bot
moved this from Reviewer Approved
to Done
in Weekly Planning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
s = samplings.sph_gaussian(sh_order=121)fails right now, because the phi angle was not calculated correctly due to numerical issues withnp.arange(it returned phi=0 twice). So I replaced it withnp.linspace, so that it always returns the correct phi angles. I also added a test to make sure it woudnt fail again.this is the same pr as here pyfar/pyfar#887