Skip to content

Conversation

@puririshi98
Copy link
Contributor

No description provided.

@puririshi98
Copy link
Contributor Author

@stadlmax to review

@puririshi98 puririshi98 requested a review from wsad1 as a code owner August 26, 2025 15:56
@puririshi98 puririshi98 added this to the 2.7.0 milestone Aug 28, 2025
@akihironitta
Copy link
Member

@puririshi98 Looks like it's missing a test case and changelog for the change. Ping me once this PR is ready :)

@akihironitta akihironitta marked this pull request as draft August 30, 2025 11:03
@puririshi98
Copy link
Contributor Author

puririshi98 commented Aug 30, 2025

yes will do over weekend was very busy during week

@puririshi98
Copy link
Contributor Author

puririshi98 commented Sep 4, 2025

will test new test case locally friday

@akihironitta akihironitta modified the milestones: 2.7.0, 2.8.0 Sep 5, 2025
@puririshi98 puririshi98 marked this pull request as ready for review September 10, 2025 04:14
@puririshi98
Copy link
Contributor Author

tests pass, ready to merge @akihironitta @rusty1s @wsad1

@puririshi98
Copy link
Contributor Author

this will fix CI: #10489

@puririshi98 puririshi98 merged commit deaf4f6 into master Nov 12, 2025
14 checks passed
@puririshi98 puririshi98 deleted the puririshi98-patch-2 branch November 12, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants