Skip to content

Conversation

@hombit
Copy link

@hombit hombit commented Dec 13, 2025

Hey, thank you for the nice crate! I've just added it to light-curve-feature. Here I propose a small usability change.

This add a public import of rand, so dependent crates don't have to specify the dependency explicitly and manually synchronize the version to one used by nuts-rs.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.97%. Comparing base (394c629) to head (ea87039).
⚠️ Report is 100 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (394c629) and HEAD (ea87039). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (394c629) HEAD (ea87039)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #48       +/-   ##
===========================================
- Coverage   83.77%   55.97%   -27.80%     
===========================================
  Files           8       29       +21     
  Lines        1923     7067     +5144     
===========================================
+ Hits         1611     3956     +2345     
- Misses        312     3111     +2799     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hombit
Copy link
Author

hombit commented Dec 15, 2025

@twiecki thanks for the review! Do I need to do anything for this to get merged?

@twiecki twiecki requested review from aseyboldt and maresb December 15, 2025 18:04
@maresb
Copy link

maresb commented Dec 16, 2025

I'm not qualified to evaluate this since I don't know rust. I'll have to defer to @aseyboldt, who is currently extremely busy. If we don't hear back, please ping again in a week or two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants