-
Notifications
You must be signed in to change notification settings - Fork 7
Support Pyodide 0.28 and bump to Python >=3.13 #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
agriyakhetarpal
wants to merge
40
commits into
pyodide:main
Choose a base branch
from
agriyakhetarpal:update/pyodide-0.27
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
f15d0e9
Bump to Node 22
agriyakhetarpal db199bb
Test against Pyodide 0.27.3
agriyakhetarpal 3940244
Fix typo
agriyakhetarpal 3ce8480
Update CHANGELOG for #57
agriyakhetarpal ccac8f9
Note compatibility with Pyodide 0.27 and later
agriyakhetarpal eacee75
Use Python 3.12 everywhere
agriyakhetarpal 7c83198
Downgrade to Pyodide 0.26.4
agriyakhetarpal 72a091f
Drop check for number of paths
agriyakhetarpal dc0cfc2
Go back to Node 20
agriyakhetarpal 9fe3724
Fix RTD builds
agriyakhetarpal 4b88204
Fix coverage path
agriyakhetarpal 8b6c1ce
Drop deprecated `ast.Str`
agriyakhetarpal 6e35b9f
Upgrade to py312 for pyupgrade
agriyakhetarpal 9b29a0e
Use `-n auto` for parallel testing
agriyakhetarpal b0e99f3
Don't depend on `tomli` for Python <3.11
agriyakhetarpal 5551c85
Update to Python 3.12 everywhere
agriyakhetarpal 6481503
Bump up Hypothesis deadline
agriyakhetarpal e16d2fe
Bisect; go down further to Pyodide 0.25.1
agriyakhetarpal 490c3f1
Bump up test suite verbosity
agriyakhetarpal 8462777
Import `encodings.cp437`
agriyakhetarpal 4ec4bdf
Update runtime module elimination docs
agriyakhetarpal af67dcc
Bump to Pyodide 0.27.3 again
agriyakhetarpal 1cd3e48
Bump to latest Node.js LTS again
agriyakhetarpal 886a1bb
Test scikit-learn example with Pyodide 0.26.4
agriyakhetarpal 02f65fb
Drop Hypothesis deadline for stdlib processing
agriyakhetarpal af067e7
All shared libraries are locally loaded
agriyakhetarpal 87b5478
Drop explicit NumPy from scikit-learn example
agriyakhetarpal 5441b38
Fix `DynamicLib` loading test
agriyakhetarpal 58f7016
Bump to Pyodide 0.27.3
agriyakhetarpal 8795efc
Add a more complex test
agriyakhetarpal ed4bde3
Handle duplicate shared libraries gracefully?
agriyakhetarpal 4b57e0f
Merge branch 'main' into update/pyodide-0.27
agriyakhetarpal 3cc8c03
Mark compatibility with Python 3.12 in README
agriyakhetarpal f70fa86
Fix coverage directory
agriyakhetarpal 7c6c3e2
Revert graceful checking for dynlib duplication
agriyakhetarpal 31a3f52
Drop `shared=True` markers
agriyakhetarpal 16b6787
Install Pyodide 0.28.0a3
agriyakhetarpal 1d44dce
Fix typo for npm Pyodide package
agriyakhetarpal f7911c5
"alpha-3", not "a3"
agriyakhetarpal cf78f2f
Bump to Python 3.13 everywhere
agriyakhetarpal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,6 +9,9 @@ on: | |
| permissions: | ||
| contents: read | ||
|
|
||
| env: | ||
| FORCE_COLOR: 3 | ||
|
|
||
| jobs: | ||
| test: | ||
| runs-on: ubuntu-latest | ||
|
|
@@ -20,10 +23,10 @@ jobs: | |
| fetch-tags: true | ||
| persist-credentials: false | ||
|
|
||
| - name: Set up Python 3.10 | ||
| - name: Set up Python 3.13 | ||
| uses: actions/setup-python@42375524e23c412d93fb67b49958b491fce71c38 # v5.4.0 | ||
| with: | ||
| python-version: "3.10" | ||
| python-version: "3.13" | ||
|
|
||
| - name: Install dependencies | ||
| run: | | ||
|
|
@@ -35,15 +38,14 @@ jobs: | |
|
|
||
| - uses: actions/setup-node@1d0ff469b7ec7b3cb9d8673fde0c81c44821de2a # v4.2.0 | ||
| with: | ||
| node-version: "20.6.1" | ||
| node-version: "22" | ||
|
|
||
| - name: Install the pyodide npm package | ||
| run: | | ||
| npm install [email protected] | ||
| run: npm install [email protected] | ||
|
|
||
| - name: Test package + examples | ||
| run: | | ||
| pytest --cov=pyodide_pack -n 2 --cov-report=xml | ||
| pytest --cov=pyodide_pack -n auto --cov-report=xml | ||
|
|
||
| - name: Upload coverage | ||
| uses: codecov/codecov-action@0565863a31f2c772f9f0395002a31e3f06189574 # v5.4.0 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,6 +12,6 @@ python: | |
| path: . | ||
|
|
||
| build: | ||
| os: ubuntu-20.04 | ||
| os: ubuntu-22.04 | ||
| tools: | ||
| python: "3.11" | ||
| python: "3.13" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import netCDF4 as nc | ||
| import numpy as np | ||
|
|
||
| dataset = nc.Dataset("memory.nc", "w", diskless=True, persist=False) | ||
| dataset.createDimension("x", 3) | ||
| var = dataset.createVariable("data", np.float32, ("x",)) | ||
| var[:] = np.array([1.0, 2.0, 3.0]) | ||
| print(f"Data: {var[:]}") | ||
| dataset.close() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| [tool.pyodide_pack] | ||
| requires = [ | ||
| "numpy", | ||
| "netcdf4", | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| [tool.pyodide_pack] | ||
| requires = [ | ||
| "numpy", | ||
| "scikit-learn" | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| { | ||
| "dependencies": { | ||
| "node-fetch": "^3.3.2", | ||
| "pyodide": "^0.24.0" | ||
| "pyodide": "^0.28.0-alpha.3" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -123,7 +123,7 @@ def test_strip_module_docstrings(): | |
| ) | ||
|
|
||
|
|
||
| @settings(deadline=300) | ||
| @settings(deadline=None) | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I can't get this test to pass within 500ms :) |
||
| @given(st.sampled_from(_get_stdlib_module_paths())) | ||
| def test_process_all_stdlib(path): | ||
| """Check that we can process all of the stdlib without crashing.""" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.