Skip to content

Conversation

@fe51
Copy link
Member

@fe51 fe51 commented Dec 12, 2025

This PR to address #528 which is part of the planned changes to the data model

It introduces the following modifications

  • Add table poses in models and add the fk to the related tables (currently nullable while the migration is being carried out)
  • Add poses schema and updates other related
  • Add poses crud
  • Add pose crud endpoints (GET, POST, PATCH, DELETE)
  • Updates camera endpoints (to reflect cameras poses)
  • Updates detections endpoints (to include poses) -> later, in migration, azimuth will be delete, as camera_id fk (even if camera_id can be still returned by api)
  • Update tests
  • Updates db diagram

What is missing (to be discussed of to handle in another PR)

  • Alembic migrations
  • Client updates -> will be done later
  • Client tests (struggled to be properly run locally)

Happy to discuss it !

@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

❌ Patch coverage is 94.84536% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.16%. Comparing base (9cba4af) to head (729b4b6).

Files with missing lines Patch % Lines
src/app/api/api_v1/endpoints/poses.py 89.47% 4 Missing ⚠️
src/app/api/api_v1/endpoints/cameras.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #531      +/-   ##
==========================================
+ Coverage   84.07%   84.16%   +0.09%     
==========================================
  Files          39       39              
  Lines        1212     1219       +7     
==========================================
+ Hits         1019     1026       +7     
  Misses        193      193              
Flag Coverage Δ
backend 84.16% <94.84%> (+0.76%) ⬆️
client ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fe51 fe51 changed the title [WIP] Introduces poses table and related endpoints udpates Introduces poses table and related endpoints udpates Dec 12, 2025
@fe51
Copy link
Member Author

fe51 commented Dec 12, 2025

@MateoLostanlen @frgfm happy to get your feedbacks !

@fe51 fe51 changed the title Introduces poses table and related endpoints udpates Introduces Poses table and related endpoints udpates Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants