-
Notifications
You must be signed in to change notification settings - Fork 29
Support the free-threaded build of Python 3.14 #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ngoldbaum
wants to merge
22
commits into
python-hyper:main
Choose a base branch
from
ngoldbaum:3.14t-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+309
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Argh: the test timing is flaky. There's probably a better way to synchronize things but I'm running out of steam. Suggestions to improve the tests are very welcome :) |
Contributor
Author
|
It also occurred to me while working on this that the ubuntu wheel builds probably benefit from the new aarch64 CI runners on github actions. That would allow skipping the slow QEMU-emulated builds on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
py_limited_apion the free-threaded build. This tells CFFI to build version-specific wheels instead of abi3 wheels.CompressorandDecompressorclass and ensures that all operations that non-atomically read or mutate state on either class happen while the lock is held. Rather than introduce possible scaling bottlenecks, I've set up thethreading.Lockto always callacquire(blocking=False), and if the lock is already held by another thread, immediately raise an error. This enforces that it's not safe to shareCompressororDecompressorinstances while compression or decompression operations are happening. This follows the approach in Add py free-threaded support + concurrent access test google/brotli#1386.Open questions: