Skip to content

Issue #53 related, get relevant viewport coords before crop #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
skudasov wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Issue #53 related, get relevant viewport coords before crop #72

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d29008a
Issue #53 related, get relevant viewport coords before crop
vnvnsldfs20 May 15, 2017
519518d
Issue #53 related, get relevant viewport coords before crop
vnvnsldfs20 May 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions needle/driver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,10 @@ def get_screenshot(self):
"""
Returns a screenshot of this element as a PIL image.
"""
# Get relevant coords in case of user scroll to element
scrolled_x = self._parent.execute_script("return window.pageXOffset;")
scrolled_y = self._parent.execute_script("return window.pageYOffset;")

d = self.get_dimensions()

# Cast values to int in order for _ImageCrop not to break
Expand All @@ -80,10 +84,10 @@ def get_screenshot(self):
image = self._parent.get_screenshot_as_image()

return image.crop((
d['left'],
d['top'],
d['left'] + d['width'],
d['top'] + d['height'],
d['left'] - scrolled_x,
d['top'] - scrolled_y,
d['left'] + d['width'] - scrolled_x,
d['top'] + d['height'] - scrolled_y,
))


Expand Down