Skip to content

Fix for miscropping on retina display #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joshuamckenty wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for miscropping on retina display #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions needle/driver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,13 @@ def get_screenshot(self):
Returns a screenshot of this element as a PIL image.
"""
d = self.get_dimensions()
devicePixelRatio = int(self._parent.execute_script("return window.devicePixelRatio"))

# Cast values to int in order for _ImageCrop not to break
d['left'] = int(d['left'])
d['top'] = int(d['top'])
d['width'] = int(d['width'])
d['height'] = int(d['height'])
d['width'] = int(d['width']) * devicePixelRatio
d['height'] = int(d['height']) * devicePixelRatio

try:
# For selenium >= 2.46.1, W3C WebDriver spec drivers (like geckodriver)
Expand Down