Skip to content

change default of installer.re-resolve from true to false #10622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
radoering wants to merge 1 commit into
base: main
Choose a base branch
from
Open

change default of installer.re-resolve from true to false #10622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion docs/configuration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,10 +348,12 @@ This setting has no effect if the server does not support HTTP range requests.

**Type**: `boolean`

**Default**: `true`
**Default**: `false`

**Environment Variable**: `POETRY_INSTALLER_RE_RESOLVE`

*Changed default from `true` to `false` in 2.3.0*

*Introduced in 2.0.0*

If the config option is _not_ set and the lock file is at least version 2.1
Expand Down
2 changes: 1 addition & 1 deletion docs/dependency-specification.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,7 +599,7 @@ The first example will only work completely if you configure Poetry to not re-re
poetry config installer.re-resolve false
```

This is a new feature of Poetry 2.0 that may become the default in a future version of Poetry.
This was a new feature of Poetry 2.0 and became the default behavior in Poetry 2.3.

{{% /warning %}}

Expand Down
2 changes: 1 addition & 1 deletion src/poetry/config/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ class Config:
"max-retries": 0,
},
"installer": {
"re-resolve": True,
"re-resolve": False,
"parallel": True,
"max-workers": None,
"no-binary": None,
Expand Down
2 changes: 1 addition & 1 deletion src/poetry/installation/installer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ def _do_install(self) -> int:
from poetry.puzzle.solver import Solver

locked_repository = Repository("poetry-locked")
reresolve = self._config.get("installer.re-resolve", True)
reresolve = self._config.get("installer.re-resolve", False)
solved_packages: dict[Package, TransitivePackageInfo] = {}
lockfile_repo = LockfileRepository()

Expand Down
12 changes: 6 additions & 6 deletions tests/console/commands/test_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def test_list_displays_default_value_if_not_set(
installer.no-binary = null
installer.only-binary = null
installer.parallel = true
installer.re-resolve = true
installer.re-resolve = false
keyring.enabled = true
python.installation-dir = {json.dumps(str(Path("{data-dir}/python")))} # {config_data_dir / "python"}
requests.max-retries = 0
Expand Down Expand Up @@ -105,7 +105,7 @@ def test_list_displays_set_get_setting(
installer.no-binary = null
installer.only-binary = null
installer.parallel = true
installer.re-resolve = true
installer.re-resolve = false
keyring.enabled = true
python.installation-dir = {json.dumps(str(Path("{data-dir}/python")))} # {config_data_dir / "python"}
requests.max-retries = 0
Expand Down Expand Up @@ -161,7 +161,7 @@ def test_unset_setting(
installer.no-binary = null
installer.only-binary = null
installer.parallel = true
installer.re-resolve = true
installer.re-resolve = false
keyring.enabled = true
python.installation-dir = {json.dumps(str(Path("{data-dir}/python")))} # {config_data_dir / "python"}
requests.max-retries = 0
Expand Down Expand Up @@ -195,7 +195,7 @@ def test_unset_repo_setting(
installer.no-binary = null
installer.only-binary = null
installer.parallel = true
installer.re-resolve = true
installer.re-resolve = false
keyring.enabled = true
python.installation-dir = {json.dumps(str(Path("{data-dir}/python")))} # {config_data_dir / "python"}
requests.max-retries = 0
Expand Down Expand Up @@ -330,7 +330,7 @@ def test_list_displays_set_get_local_setting(
installer.no-binary = null
installer.only-binary = null
installer.parallel = true
installer.re-resolve = true
installer.re-resolve = false
keyring.enabled = true
python.installation-dir = {json.dumps(str(Path("{data-dir}/python")))} # {config_data_dir / "python"}
requests.max-retries = 0
Expand Down Expand Up @@ -373,7 +373,7 @@ def test_list_must_not_display_sources_from_pyproject_toml(
installer.no-binary = null
installer.only-binary = null
installer.parallel = true
installer.re-resolve = true
installer.re-resolve = false
keyring.enabled = true
python.installation-dir = {json.dumps(str(Path("{data-dir}/python")))} # {config_data_dir / "python"}
repositories.foo.url = "https://foo.bar/simple/"
Expand Down