Skip to content

Conversation

@nothing-991
Copy link

@nothing-991 nothing-991 commented Dec 31, 2025

This PR clarifies how Poetry handles conflicting configuration settings when the same setting is defined both locally (in poetry.toml) and globally (in config.toml).
A new note has been added to the Configuration documentation:
Note: If a setting is defined in both poetry.toml (local/project) and config.toml (global), the local/project configuration takes precedence over the global configuration.
This change helps contributors and users understand which configuration will apply without needing to test it themselves.
No code changes were made—only the documentation has been updated.

Summary by Sourcery

Documentation:

  • Document that local/project configuration in poetry.toml overrides global configuration in config.toml when the same setting is defined in both.

@sourcery-ai
Copy link

sourcery-ai bot commented Dec 31, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Documents that when the same configuration key is set both locally in poetry.toml and globally in config.toml, the local/project setting takes precedence, by adding a note to the configuration documentation.

File-Level Changes

Change Details Files
Document precedence between local/project and global Poetry configuration settings.
  • Add a documentation note stating that when a setting exists in both local poetry.toml and global config.toml, the local/project configuration wins
  • Place the new note directly after the existing explanation of poetry.toml and before the warning about checking in this file
docs/configuration.md

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue, and left some high level feedback:

  • While you’re updating this section, consider fixing the existing shortcode mismatch where the {{% warning %}} block is closed with {{% /note %}}, which could lead to rendering issues in the docs.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- While you’re updating this section, consider fixing the existing shortcode mismatch where the `{{% warning %}}` block is closed with `{{% /note %}}`, which could lead to rendering issues in the docs.

## Individual Comments

### Comment 1
<location> `docs/configuration.md:43-44` </location>
<code_context>
+the local/project configuration takes precedence over the global configuration.
+{{% /note %}}
+
 {{% warning %}}
 Be mindful about checking in this file into your repository since it may contain user-specific or sensitive information.
 {{% /note %}}
</code_context>

<issue_to_address>
**suggestion (typo):** Consider rephrasing this sentence to avoid the awkward "checking in this file into" construction.

The phrase "Be mindful about checking in this file into your repository" is grammatically awkward because of the "about … into" combination. Consider rewording to something like "Be mindful when checking this file into your repository" or "Be mindful about checking this file into your repository" for better flow.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment on lines 43 to 44
{{% warning %}}
Be mindful about checking in this file into your repository since it may contain user-specific or sensitive information.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (typo): Consider rephrasing this sentence to avoid the awkward "checking in this file into" construction.

The phrase "Be mindful about checking in this file into your repository" is grammatically awkward because of the "about … into" combination. Consider rewording to something like "Be mindful when checking this file into your repository" or "Be mindful about checking this file into your repository" for better flow.

@nothing-991 nothing-991 force-pushed the docs-config-precedence-10329 branch from c48c984 to 8d0ec74 Compare December 31, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant