Make NoneType annotation error a new code #20222
Open
+26
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyattscarpenter
commented
Nov 11, 2025
This comment has been minimized.
This comment has been minimized.
Change the code of "NoneType should not be used as a type, please use None instead" error to be a new code, so that people who don't like this rule can disable it easily. I haven't made this a subcode of valid-type because NoneType is actually a valid type; it's just dispreferred. I have added the documentation for the new code, but haven't added any new tests (the old test still runs fine). Fixes python#20218
for more information, see https://pre-commit.ci
A5rocks
approved these changes
Nov 12, 2025
Co-authored-by: A5rocks <[email protected]>
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the code of "NoneType should not be used as a type, please use None instead" error to be a new code, so that people who don't like this rule can disable it easily.
I haven't made this a subcode of valid-type because NoneType is actually a valid type; it's just dispreferred.
I have added the documentation for the new code, but haven't added any new tests (the old test still runs fine).
Fixes #20218