Add src to mypy_path in .mypy.ini #15629
Closed
+11
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perheld
added
ciflow/trunk
module: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15629
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 268 PendingAs of commit fcabc82 with merge base 80c9040 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
perheld
force-pushed
the
ph-mypy-ops-mypy.ini
branch
from
09501c5 to
b911dc5
Compare
Collaborator
|
@mergennachin this helps a a lot when checking with mypy is it OK to do? |
perheld
added
the
partner: arm
perheld
force-pushed
the
ph-mypy-ops-mypy.ini
branch
from
b911dc5 to
5079f4f
Compare
Collaborator
Author
|
lintrunner-mypy is not running for this PR because no python file is changed. Is there some clever way I can force run it? |
perheld
force-pushed
the
ph-mypy-ops-mypy.ini
branch
from
5079f4f to
12a3319
Compare
Add src to mypy_path to get rid of lots of missing import warnings. Signed-off-by: [email protected] Change-Id: I4ed1a08cfe185aa956c6408fefa5aadeb567d4c1
Fix mypy warning about type. Signed-off-by: [email protected] Change-Id: I09a5f75943c12b304a2e4d4ff6af8739021aeb44
perheld
force-pushed
the
ph-mypy-ops-mypy.ini
branch
from
12a3319 to
fcabc82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add src to mypy_path to get rid of lots of missing import warnings.
Signed-off-by: [email protected]
Change-Id: I4ed1a08cfe185aa956c6408fefa5aadeb567d4c1
cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai