FEATURE: per-topic unsubscribe option in emails #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Review by Qodo (Alpha)Analysis CompletedPublished 1 inline comment(s) |
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Comment on lines
+98
to
+116
| def unsubscribe | ||
| @topic_view = TopicView.new(params[:topic_id], current_user) | ||
|
|
||
| if slugs_do_not_match || (!request.format.json? && params[:slug].blank?) | ||
| return redirect_to @topic_view.topic.unsubscribe_url, status: 301 | ||
| end | ||
|
|
||
| tu = TopicUser.find_by(user_id: current_user.id, topic_id: params[:topic_id]) | ||
|
|
||
| if tu.notification_level > TopicUser.notification_levels[:regular] | ||
| tu.notification_level = TopicUser.notification_levels[:regular] | ||
| else | ||
| tu.notification_level = TopicUser.notification_levels[:muted] | ||
| end | ||
|
|
||
| tu.save! | ||
|
|
||
| perform_show_response | ||
| end |
There was a problem hiding this comment.
[action_required] [Null Reference in Unsubscribe Action]
• The TopicUser.find_by(...) call returns nil when no record exists for the user/topic combination
• The code immediately accesses tu.notification_level without checking if tu is nil
• This will cause a NoMethodError crash when users click unsubscribe links for topics they've never visited
• Users can receive notifications without having a TopicUser record (e.g., via @mentions)
Agent Prompt
Copy this prompt and use it to remediate the issue with your preferred AI generation tools
## Issue description
The `unsubscribe` action in `topics_controller.rb` calls `TopicUser.find_by(...)` which can return `nil` when no record exists. The code then immediately accesses `tu.notification_level` without null checking, causing a NoMethodError crash.
## Issue Context
- `TopicUser` records are created when users interact with topics (visit, read, etc.)
- Users can receive notifications without having interacted with a topic (e.g., @mentions, category watching)
- Clicking unsubscribe link for such topics crashes the application
## Fix Focus Areas
- app/controllers/topics_controller.rb[105-114]
Add a nil check for `tu` before accessing its properties. If `tu` is nil, use `TopicUser.change` to create a new record with muted notification level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmark PR from qodo-benchmark/discourse-qodo#2