FEATURE: Localization fallbacks (server-side) #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FallbackLocaleList object tells I18n::Backend::Fallbacks what order the languages should be attempted in. Because of the translate_accelerator patch, the SiteSetting.default_locale is *not* guaranteed to be fully loaded after the server starts, so a call to ensure_loaded! is added after the locale is set for the current user. The declarations of config.i18n.fallbacks = true in the environment files were actually garbage, because the I18n.default_locale was SiteSetting.default_locale, so there was nothing to fall back to. *derp*
Code Review by Qodo (Alpha)Analysis CompletedPublished 2 inline comment(s) |
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Comment on lines
+62
to
+65
| def ensure_loaded!(locale) | ||
| @loaded_locales ||= [] | ||
| load_locale locale unless @loaded_locales.include?(locale) | ||
| end |
There was a problem hiding this comment.
[remediation_recommended] [Thread-safety concern in ensure_loaded!]
• The new ensure_loaded! method uses @loaded_locales ||= [] outside of any mutex synchronization
• Multiple threads could race on this initialization, each creating separate arrays
• While load_locale has internal mutex protection preventing duplicate loading, the unsynchronized access is a code smell
• The pattern is inconsistent with how load_locale handles @loaded_locales access (inside LOAD_MUTEX)
Agent Prompt
Copy this prompt and use it to remediate the issue with your preferred AI generation tools
## Issue description
The ensure_loaded! method accesses @loaded_locales outside of mutex synchronization, creating a race condition window and pattern inconsistency with load_locale.
## Issue Context
load_locale already has internal synchronization via LOAD_MUTEX and checks if the locale is already loaded. The external check in ensure_loaded! is redundant and introduces thread-safety concerns.
## Fix Focus Areas
- lib/freedom_patches/translate_accelerator.rb[62-65]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmark PR from qodo-benchmark/discourse-qodo#7