Add support for external templates #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasgasco
force-pushed
the
allow-external-templates
branch
from
32c47bd to
b2caf98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a new
externalTemplatesconfiguration option.Contrary to externalPaths, which allows users to include copies from an external source,
externalTemplatesallows users to include templates from an external source.This is necessary to move the kits (e.g.
cards-kit) copies toqonto-js, as per our desidered architecture, see https://qonto.slack.com/archives/C05F2DR6H4P/p1750838859015319The changes can be tested by checking out this branch and running
pnpm run lint:unused-translationsinqonto-jswith and without the config option.