Add CMake Presets support and related improvements #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrkunTokdemir
requested review from
benchoq,
leena-miettinen and
lugerard
and removed request for
lugerard
OrkunTokdemir
force-pushed
the
orkun_presets_test_12_10_2025
branch
6 times, most recently
from
8749eed to
4e8ed8a
Compare
lugerard
reviewed
Nov 17, 2025
qt-cpp/test/runTest.mts
Outdated
| const quietArgs = [...args, ...getQuietVSCodeArgs()]; | ||
| const required = ['ms-vscode.cmake-tools', localQtCoreVsix]; | ||
| const required: ExtensionInstallInfo[] = [ | ||
| { idOrVsix: 'ms-vscode.cmake-tools', preRelease: true }, |
Collaborator
There was a problem hiding this comment.
Is preRelease needed here? I don't see commands.test.mts and extension.test.mts depending on it.
benchoq
previously approved these changes
Nov 17, 2025
OrkunTokdemir
force-pushed
the
orkun_presets_test_12_10_2025
branch
from
4e8ed8a to
ef807a7
Compare
…ions in tests Update installExtensionWithRetry to accept ExtensionInstallInfo object with optional preRelease flag. This allows test runners to install pre-release versions of extensions like CMake Tools when needed. Update all test runners to use the new interface.
Add qtDir property to the ResolveResult returned by prepareCMakeQtEnvWithVersion. This provides direct access to the Qt6_DIR path without requiring callers to reconstruct it from the leaf path. Remove automatic process.env.Qt6_DIR setting to give callers explicit control over environment configuration.
Task-number: [VSCODEEXT-64](https://bugreports.qt.io/browse/VSCODEEXT-64)
OrkunTokdemir
force-pushed
the
orkun_presets_test_12_10_2025
branch
from
ef807a7 to
715b260
Compare
Collaborator
leena-miettinen
left a comment
leena-miettinen
left a comment
There was a problem hiding this comment.
Looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive CMake Presets support to the Qt C++ extension and improves the testing infrastructure.
Changes
CMake Presets Support
Testing Improvements
Code Cleanup
Testing
The changes include:
Related Issues
Task-number: VSCODEEXT-64