Skip to content

FROMLIST: usb: typec: hd3ss3220: Enable VBUS based on role state #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
swatagar wants to merge 1 commit into
base: tech/bus/usb/phy
Choose a base branch
from
Open

FROMLIST: usb: typec: hd3ss3220: Enable VBUS based on role state #656

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 21 additions & 9 deletions drivers/usb/typec/hd3ss3220.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,23 @@ static const struct typec_operations hd3ss3220_ops = {
.port_type_set = hd3ss3220_port_type_set,
};

static void hd3ss3220_regulator_control(struct hd3ss3220 *hd3ss3220, bool on)
{
int ret;

if (regulator_is_enabled(hd3ss3220->vbus) == on)
return;

if (on)
ret = regulator_enable(hd3ss3220->vbus);
else
ret = regulator_disable(hd3ss3220->vbus);

if (ret)
dev_err(hd3ss3220->dev,
"vbus regulator %s failed: %d\n", on ? "disable" : "enable", ret);
}

static void hd3ss3220_set_role(struct hd3ss3220 *hd3ss3220)
{
enum usb_role role_state = hd3ss3220_get_attached_state(hd3ss3220);
Expand All @@ -221,6 +238,9 @@ static void hd3ss3220_set_role(struct hd3ss3220 *hd3ss3220)
break;
}

if (hd3ss3220->vbus && !hd3ss3220->id_gpiod)
hd3ss3220_regulator_control(hd3ss3220, role_state == USB_ROLE_HOST);

hd3ss3220->role_state = role_state;
}

Expand Down Expand Up @@ -330,18 +350,10 @@ static const struct regmap_config config = {
static irqreturn_t hd3ss3220_id_isr(int irq, void *dev_id)
{
struct hd3ss3220 *hd3ss3220 = dev_id;
int ret;
int id;

id = gpiod_get_value_cansleep(hd3ss3220->id_gpiod);
if (!id)
ret = regulator_enable(hd3ss3220->vbus);
else
ret = regulator_disable(hd3ss3220->vbus);

if (ret)
dev_err(hd3ss3220->dev,
"vbus regulator %s failed: %d\n", id ? "disable" : "enable", ret);
hd3ss3220_regulator_control(hd3ss3220, !id);

return IRQ_HANDLED;
}
Expand Down