-
Notifications
You must be signed in to change notification settings - Fork 21
platforms: add support for Arduino UNO Q #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi, this builds upon the commit from @SuMere in #46, but I can't push to his branch nor mark it as non-draft. @ndechesne I've implemented the naming of emmc-16GB and emmc-16GB-arduino; however, I have NOT updated the list of partitions to match the ones from RB1; do we want to transition to the new names as to support upcoming boot firmware? we should probably discuss if there is a risk of end-user impact or for the AppLab upgrade steps |
|
|
We should probably align the partitions here, the new boot firmware is supposed to drop soon. |
|
NB: the only difference between the previous RB1 partitions.conf and the initial UNO Q one is that hyp_a and hyp_b were bumped from 5kiB to 8MiB: |
| uefi.elf) ;; | ||
| uefi_dtbs.xz) ;; | ||
| uefi_sec.mbn) ;; | ||
| userdata.img) ;; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Break this one in a separated commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
TBH I don't really like the fact we list the Arduino userdata partition. I think ptool should mix:
I think we should address this globally in ptool at some point, but I lack the time to contribute this right now. |
Arduino images for the UNO Q have a separate partition for the home directory that allow to optionally preserve user data when reinstalling the OS. Allow this name in anticipation of adding UNO Q platform support. Signed-off-by: Loïc Minier <[email protected]>
Add a a new qrb2210-unoq platform with two storage configurations and corresponding partitions.conf files: - emmc-16GB: identical to RB1, works with the Android version of the Agatti boot binaries and a chainloaded U-Boot - emmc-16GB-arduino: same as emmc-16GB but with an extra userdata partition, as done in Arduino factory images; this partition can optionally be preserved when reflashing the OS These are based on an older version of qrb2210-rb1/emmc/partitions.conf, but with hyp_a and hyp_b bumped from 512kiB to 8MiB. Signed-off-by: Riccardo Mereu <[email protected]> Signed-off-by: Loïc Minier <[email protected]>
In anticipation of new Agatti boot binaries notably for the qrb2210-rb1 platform, the partition list was updated to get more A/B partitions and drop the unversioned names, a number of GUIDs were also updated. Follow along and update the qrb2210-unoq partitions as well. Signed-off-by: Loïc Minier <[email protected]>
Yeah I agree; I did it in a separate commit to have the original (factory) partitions in the history, hope that makes sense |
|
Note from the other PR: |
|
I think 0fc63daf-8483-4772-8e79-3d69d8477de4 would be more generic. |
I agree. ptool is supposed to be used to 'reset' a system in a "System Ready" like state. so even 'rootfs' arguably does not belong here. but as you said, we need something that works for us today. |
Add a a new qrb2210-unoq platform with two storage configurations and
corresponding partitions.conf files:
Agatti boot binaries and a chainloaded U-Boot
partition, as done in Arduino factory images; this partition can
optionally be preserved when reflashing the OS