[backport] Fix babel error issue #13646
Merged
+10,079
−1,046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when lang: en is passed, babel-english needs to be installed. This follows up fix on tinytex R package too about new error handling cause is new pandoc way to setup babel, and maybe new babel error in log
Updated regex to accept both backtick-quote (`Spanish') and straight-quote
('Spanish') formats for detecting missing hyphenation packages.
Added unit tests and modified smoke-all tests to skip package removal on CI.
# Conflicts:
# news/changelog-1.9.md
# tests/docs/smoke-all/2024/08/30/10291/latex-hyphen-lang-es-no-install.qmd
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
The static journal extensions (acs, elsevier) in tests were frozen at Sept 2023 versions, causing issues with current Quarto including PDF rendering hangs. Modified render-format-extension.test.ts to update extensions from quarto-journals GitHub repos before running tests. Falls back to committed versions on network failure for CI reliability. Updated committed extension files to current versions: - acs: Added fancy-text and latex-environment dependencies - elsevier: Added Lua filter and restructured partials Tests verify format rendering (HTML/PDF/variants) while extension-render-journals.test.ts tests template scaffolding. Both files serve different purposes. Related to #13647 (cherry picked from commit c3149a9)
The acs and elsevier journal extensions copy .bst and .cls files to the test directory during rendering. These files were not being cleaned up by teardown, leaving artifacts after test runs. (cherry picked from commit b8421ca)
Added comment explaining that committed extension files serve as fallback and don't need frequent updates since tests fetch latest versions. Recommends updating committed files when extension-related issues occur to document working versions. (cherry picked from commit 2e6e1fa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
This is backport PR against v1.8 for change in
when lang: en is passed, babel-english needs to be installed.
This follows up fix on tinytex R package too about new error handling
cause is new pandoc way to setup babel, and maybe new babel error in log