Skip to content

Conversation

@epugh
Copy link
Contributor

@epugh epugh commented Feb 20, 2024

…Github, which should help us keep our Releases up to date.

This also runs the test and build phase on any branch created, which is good for testing.

…Github, which should help us keep our Releases up to date.
@epugh epugh requested review from pbartusch and renekrie February 20, 2024 17:33
@epugh
Copy link
Contributor Author

epugh commented Feb 20, 2024

And of course "SmuiVersionSpec" failed because to pass we have to bump every branch... With this in place, we can increment build.sbt version once, and all branches pick it up... and then merge to main regularly, and THEN do the tag/push to DockerHub!

@renekrie
Copy link
Collaborator

I would suggest an alternative strategy: We simply protect branch main from direct pushes so that only PRs are allowed to be merged and then they would be released as they are right now. Tests are being run automatically on PR's. This way we would not need tags, and enforce testing and release more often ;-)

@mkr
Copy link
Collaborator

mkr commented Feb 21, 2024

Both approaches (merging to main but only releasing by pushing a tag, merging to main and always releasing directly) work. We use the first one in the elasticsearch-ltr plugin actions. The latter brings real CI/CD but can have the drawback that every minor release gets its own Docker image tag and you need some cleanup policies in your Docker repo. Probably not a problem with SMUI (relatively little development, compressed image size 200MB) but can be with software that gets 10 merges to master a day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants