Inherit Request class from ActionDispatch if available

[bdewater-thatch]

I ran into #145, but figured that inside a Rails app the least surprising thing would be for req to be like an ::ActionDispatch::Request instead of patching my own remote_ip method in Rack::Attack::Request.

[grzuy]

Hey @bdewater-thatch,

Thanks for the PR!

That's interesting, never though about that.

I think it you're right that would be the most unsurprising implementation if we were doing this for the first time.
Considering the amount of code out there calling methods on these req objects, we need to kind of "make sure" we're not breaking users rule blocks...

Need to take a deeper look to assess that I guess...

@santib thoughts?

[santib]

@grzuy I don't know how we could check that, if even possible. But changing the base class seems like a breaking change to me, so I think we could do this but we'd need to release a new major version and add appropriate warnings in the CHANGELOG.

[bdewater-thatch]

Hey @grzuy, long time no see :)

I agree there's risk here of breaking changes but hopefully not too bad. The interfaces of both are very similar if not identical.

My first sanity check was:

Rack::Request.instance_methods - ActionDispatch::Request.instance_methods
# => [] 

Then the sources itself:

• https://github.com/rack/rack/blob/v3.2.3/lib/rack/request.rb includes Env and Helpers and implements only 4 instance methods. delete_param and update_param come from `Env but are overridden.
• https://github.com/rails/rails/blob/v8.0.3/actionpack/lib/action_dispatch/http/request.rb also includes Rack::Request::Env and Rack::Request::Helpers, implements ip directly, implements params via ActionDispatch::Http::Parameters, and gets delete_param and update_param from Rack::Request::Env.