-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Add string type filtering for iz/izz commands (issue #18821) #24735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add string type filtering for iz/izz commands (issue #18821) #24735
Conversation
vicky-dx
commented
Oct 23, 2025
- Added support for filtering strings by type: iza (ascii), izu (utf8), izw (wide/utf16), izW (wide32)
- Implemented colon syntax for charset names: iz:ascii, iz:utf8, iz:wide, iz:wide32, iz:base64
- Added str_type field to RCoreBinFilter struct for passing filter through call chain
- Modified _print_strings to filter based on RBinString type field
- Updated help messages to document new filtering options
- All filters work with both iz (data sections) and izz (whole binary) commands
- Supports combination with other modifiers (json, quiet, radare mode)
|
In file included from cmd.c:97: warnings are considered errors. fix the build please |
- Added support for filtering strings by type: iza (ascii), izu (utf8), izw (wide/utf16), izW (wide32) - Implemented colon syntax for charset names: iz:ascii, iz:utf8, iz:wide, iz:wide32, iz:base64 - Added str_type field to RCoreBinFilter struct for passing filter through call chain - Modified _print_strings to filter based on RBinString type field - Updated help messages to document new filtering options - All filters work with both iz (data sections) and izz (whole binary) commands - Supports combination with other modifiers (json, quiet, radare mode) Resolves radareorg#18821
- Ignore .personal_files/ directory for work-in-progress files - Ignore TESTING_*.md files - Ignore Windows Zone.Identifier files - Ignore test backup files
1718440 to
a786a70
Compare
libr/core/cmd_info.inc.c
Outdated
| bool rdump = false; | ||
| int str_type_filter = 0; | ||
| RCoreBinFilter filter = {0}; | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
empty lines with a tab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as reported by the lint script: ibr/core/cmd_info.inc.c:1429:
libr/core/cmd_info.inc.c:1463:
libr/core/cmd_info.inc.c:1502:
libr/core/cmd_info.inc.c:1516:
|
please fix the ci tests, the pr lgtm |
|
db/cmd/charset <- check why this test is broken |
|
ping |
@trufae The I've also verified that:
The validation function ➤ cd /home/vicky/radare2 && r2r test/db/cmd/charset 2>&1
INFO: Running from /home/vicky/radare2/test
Already up to date.
Loaded 13 tests.
[13/13] 13 OK 0 BR 0 XX 0 SK 0 FX |