#1310 Import saves from other tools #1309

langonginc · 2026-01-24T12:18:05Z

Copilot

Pull request overview

This PR adds functionality to import railway map projects from the AARC (Another Awesome Rail Creator) platform into Rail Map Painter. The implementation includes a conversion utility that transforms AARC's data format into RMP's graph structure, and a multi-step UI modal that allows users to upload AARC files and select their preferred station style.

Changes:

Added AARC-to-RMP conversion utility with support for stations, lines, text tags, and interchange detection
Created a two-step import modal with file upload and station style selection
Added internationalization support for 8 city-specific station styles
Integrated the import feature into the existing "Open" menu

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 9 comments.

File	Description
src/util/import-from-aarc.ts	Core conversion logic that transforms AARC save format to RMP graph structure, including station creation, line rendering, and interchange detection
src/components/page-header/import-from-aarc.tsx	Multi-step modal component for uploading AARC files and selecting station styles
src/components/page-header/open-actions.tsx	Integration of new import modal into the existing "Open" menu
src/i18n/translations/en.json	English translations for the import feature UI, including city names and user messages

src/components/page-header/import-from-aarc.tsx

src/util/import-from-aarc.ts

Copilot · 2026-01-24T12:22:08Z

src/components/page-header/import-from-aarc.tsx

+ * Simple modal that accepts pasted/imported text in a textarea.
+ * - Close button simply closes the modal.
+ * - Import button calls onImport(text) and then closes the modal.


This JSDoc comment is outdated and doesn't accurately describe the component's functionality. The component is a multi-step modal with file upload, station type selection, and confirmation steps, not a simple textarea-based modal. The comment should be updated to reflect the actual implementation.

Suggested change

* Simple modal that accepts pasted/imported text in a textarea.

* - Close button simply closes the modal.

* - Import button calls onImport(text) and then closes the modal.

* Modal for importing a rail map from AARC data in a two-step flow.

*

* Step 1:

* - User pastes AARC data into a textarea and triggers import.

* - The data is converted into a temporary graph instance and the node/edge

* counts are calculated for preview.

*

* Step 2:

* - On confirmation, the temporary graph replaces the current graph,

* the SVG viewBox/zoom are reset, runtime state is refreshed, and the

* updated graph is saved.

*

* @param isOpen Controls whether the modal is visible.

* @param onClose Callback invoked to close the modal; also used after a

* successful import and confirmation.

src/util/import-from-aarc.ts

Copilot · 2026-01-24T12:22:09Z

src/util/import-from-aarc.ts

+export const convertAarcToRmp = (
+    aarc: string,
+    graph: MultiDirectedGraph<NodeAttributes, EdgeAttributes, GraphAttributes>,
+    stationTypeOption: StationTypeOption = StationTypeOption.Suzhou
+) => {
+    stationIds.clear();
+    stationPoints.clear();
+    interchangeGroups.clear();
+    const aarcSave = JSON.parse(aarc);
+
+    if (!isAarcSave(aarcSave)) {
+        return false;
+    }
+
+    // Create stations and virtual nodes.
+    aarcSave.points.forEach(point => {
+        stationPoints.set(point.id, point);
+        if (point.sta === 1) {
+            createStation(graph, point, stationTypeOptions[stationTypeOption].basic);
+        } else {
+            createMiscNode(graph, point, MiscNodeType.Virtual);
+        }
+    });
+
+    // Create lines.
+    aarcSave.lines.forEach(line => {
+        createLine(graph, line);
+    });
+
+    // Update interchanges.
+    const groups = findInterchangeGroups(graph);
+
+    let index = 0;
+    groups.forEach(ids => {
+        createInterchange(graph, index, ids, stationTypeOption);
+        index++;
+    });
+
+    // Create text tags.
+    aarcSave.textTags.forEach(tag => {
+        if (tag.forId === undefined) {
+            handleTextTag(graph, tag, aarcSave.config);
+        } else {
+            const forId = tag.forId!;
+            const line = aarcSave.lines.find(l => l.id === forId);
+            if (line) {
+                const { theme } = generateLineStyleType(line.type, line.colorPre ?? 0, line.color);
+                if (line.type === 1) {
+                    handleTextTag(graph, tag, aarcSave.config, theme);
+                } else {
+                    createMiscNode(graph, { id: tag.id, pos: tag.pos }, MiscNodeType.GzmtrLineBadge, {
+                        names: [tag.text ?? (line.name || ''), tag.textS ?? (line.nameSub || '')],
+                        color: theme,
+                    });
+                }
+            }
+        }
+    });
+
+    // Update station types and populate transfers.
+    stationIds.forEach(id => {
+        if (graph.hasNode(id) && id.startsWith('stn')) {
+            autoUpdateStationType(graph, id as StnId);
+            autoPopulateTransfer(graph, id as StnId);
+        }
+    });
+
+    return true;
+};


This new import functionality lacks test coverage. Given that other utility functions in this directory have comprehensive test files (e.g., change-types.test.ts, save.test.ts, to-rmg.test.ts), a test file should be added to verify the AARC import conversion logic, including edge cases like malformed JSON, invalid data structures, and various station type configurations.

src/components/page-header/import-from-aarc.tsx

src/util/import-from-aarc.ts

src/components/page-header/import-from-aarc.tsx

thekingofcity

LGTM

langonginc added 7 commits January 8, 2026 10:08

#1286 Fix Beijing subway basic station name offset

a54db7e

first commit

1283ed2

Import from aarc

f58fc40

Merge branch 'main' into aarc

f60d26d

add interchange and text nodes

9618e35

detect

7bc8084

english ver

0f3214c

Copilot AI review requested due to automatic review settings January 24, 2026 12:18

Copilot started reviewing on behalf of langonginc January 24, 2026 12:18 View session

Copilot AI reviewed Jan 24, 2026

View reviewed changes

update translation and lint

46d8ffd

thekingofcity self-requested a review January 24, 2026 12:39

Try-catch and i18n

0bc2459

langonginc changed the title ~~Import saves from other platforms~~ Import saves from other tools Jan 25, 2026

langonginc and others added 7 commits January 25, 2026 09:53

change station type

d3547f1

fix previous

affec9b

delete docs

2636e71

rename

13bea15

update translation

448a981

remove close button

6ff1a79

reorder import

662874f

thekingofcity changed the title ~~Import saves from other tools~~ #1310 Import saves from other tools Jan 25, 2026

thekingofcity approved these changes Jan 25, 2026

View reviewed changes

thekingofcity merged commit c095a41 into main Jan 25, 2026
1 check passed

thekingofcity deleted the aarc branch January 25, 2026 02:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#1310 Import saves from other tools #1309

#1310 Import saves from other tools #1309

Uh oh!

langonginc commented Jan 24, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jan 24, 2026

Uh oh!

Uh oh!

Copilot AI Jan 24, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thekingofcity left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

- * Simple modal that accepts pasted/imported text in a textarea.
- * - Close button simply closes the modal.
- * - Import button calls onImport(text) and then closes the modal.
+ * Modal for importing a rail map from AARC data in a two-step flow.
+ *
+ * Step 1:
+ * - User pastes AARC data into a textarea and triggers import.
+ * - The data is converted into a temporary graph instance and the node/edge
+ *   counts are calculated for preview.
+ *
+ * Step 2:
+ * - On confirmation, the temporary graph replaces the current graph,
+ *   the SVG viewBox/zoom are reset, runtime state is refreshed, and the
+ *   updated graph is saved.
+ *
+ * @param isOpen Controls whether the modal is visible.
+ * @param onClose Callback invoked to close the modal; also used after a
+ *                successful import and confirmation.

#1310 Import saves from other tools #1309

#1310 Import saves from other tools #1309

Uh oh!

Conversation

langonginc commented Jan 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jan 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Jan 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thekingofcity left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

langonginc commented Jan 24, 2026 •

edited

Loading