Skip to content

Cleanup - squid:S2162 - equals methods should be symmetric and work f… #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
m-ezzat wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Cleanup - squid:S2162 - equals methods should be symmetric and work f… #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion rakam-spi/src/main/java/org/rakam/analysis/CalculatedUserSet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,10 @@ public CalculatedUserSet(Optional<String> collection, Optional<String> dimension
@Override
public boolean equals(Object o) {
if (this == o) return true;
if (!(o instanceof CalculatedUserSet)) return false;

if (o == null) return false;

if (this.getClass() != o.getClass()) return false;

CalculatedUserSet that = (CalculatedUserSet) o;

Expand Down
6 changes: 4 additions & 2 deletions rakam-spi/src/main/java/org/rakam/collection/Event.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,8 @@ public String toString() {
@Override
public boolean equals(Object o) {
if (this == o) return true;
if (!(o instanceof Event)) return false;
if (o == null) return false;
if (this.getClass() != o.getClass()) return false;

Event event = (Event) o;

Expand Down Expand Up @@ -188,7 +189,8 @@ public String toString() {
@Override
public boolean equals(Object o) {
if (this == o) return true;
if (!(o instanceof EventContext)) return false;
if (o == null) return false;
if (this.getClass() != o.getClass()) return false;

EventContext context = (EventContext) o;

Expand Down
3 changes: 2 additions & 1 deletion rakam-spi/src/main/java/org/rakam/collection/EventList.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ public String toString() {
@Override
public boolean equals(Object o) {
if (this == o) return true;
if (!(o instanceof EventList)) return false;
if (o == null) return false;
if (this.getClass() != o.getClass()) return false;

EventList eventList = (EventList) o;

Expand Down
5 changes: 4 additions & 1 deletion rakam-spi/src/main/java/org/rakam/collection/SchemaField.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,10 @@ public boolean equals(Object o)
if (this == o) {
return true;
}
if (!(o instanceof SchemaField)) {
if (o == null) {
return false;
}
if (this.getClass() != o.getClass()) {
return false;
}

Expand Down
3 changes: 2 additions & 1 deletion rakam-spi/src/main/java/org/rakam/config/JDBCConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,8 @@ public String convertScheme(String scheme) {
@Override
public boolean equals(Object o) {
if (this == o) return true;
if (!(o instanceof JDBCConfig)) return false;
if (o == null) return false;
if (this.getClass() != o.getClass()) return false;

JDBCConfig that = (JDBCConfig) o;

Expand Down
2 changes: 1 addition & 1 deletion rakam-spi/src/main/java/org/rakam/plugin/ContinuousQuery.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public boolean equals(Object o)
if (this == o) {
return true;
}
if (!(o instanceof ContinuousQuery)) {
if (this.getClass() != o.getClass()) {
return false;
}

Expand Down
5 changes: 4 additions & 1 deletion rakam-spi/src/main/java/org/rakam/report/QueryResult.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,10 @@ public boolean equals(Object o)
if (this == o) {
return true;
}
if (!(o instanceof QueryResult)) {
if (o == null) {
return false;
}
if (this.getClass() != o.getClass()) {
return false;
}

Expand Down
3 changes: 2 additions & 1 deletion rakam-spi/src/main/java/org/rakam/util/ProjectCollection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ public ProjectCollection(String project, String collection) {
@Override
public boolean equals(Object o) {
if (this == o) return true;
if (!(o instanceof ProjectCollection)) return false;
if (o == null) return false;
if (this.getClass() != o.getClass()) return false;

ProjectCollection that = (ProjectCollection) o;

Expand Down
3 changes: 2 additions & 1 deletion rakam-spi/src/main/java/org/rakam/util/SuccessMessage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ public static SuccessMessage success(String message) {
@Override
public boolean equals(Object o) {
if (this == o) return true;
if (!(o instanceof SuccessMessage)) return false;
if (o == null) return false;
if (this.getClass() != o.getClass()) return false;

SuccessMessage that = (SuccessMessage) o;

Expand Down