Skip to content

[dev-v2.10] Remove obsolete sriov chart #4698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: dev-v2.10
Choose a base branch
from
Open

[dev-v2.10] Remove obsolete sriov chart #4698

wants to merge 5 commits into from

Conversation

@mgfritch
Copy link
Contributor

@mgfritch mgfritch commented Nov 7, 2024

Issue: rancher/rancher#47915

Problem

Remove the deprecated sriov and node-feature-discovery charts from the rancher v2.10 release.

See also:

@mgfritch mgfritch requested review from a team as code owners November 7, 2024 04:58
@github-actions
Copy link

github-actions bot commented Nov 7, 2024

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@mgfritch mgfritch requested a review from nicholasSUSE November 7, 2024 15:35
@github-actions
Copy link

github-actions bot commented Nov 7, 2024

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@mgfritch
Remove rancher-sriov and rancher-nfd packages
aae662a 
remove deprecated sriov and node-feature-discovery sources

Signed-off-by: Michael Fritch <[email protected]>
@mgfritch
Remove obsolete sriov chart assets
9dcbc9a 
Signed-off-by: Michael Fritch <[email protected]>
@mgfritch
Update incorrect validate comment
6a7defc 
fixup comment to a non-existent `longhorn-controller` that has a ref
to the removed `hardened-sriov-cni` image repo

Signed-off-by: Michael Fritch <[email protected]>
@mgfritch
make index
72d49ad
@mgfritch
Add removed charts to the release.yaml
c9899b8 
Signed-off-by: Michael Fritch <[email protected]>
@github-actions
Copy link

github-actions bot commented Nov 8, 2024

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

nicholasSUSE
nicholasSUSE requested changes Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@nicholasSUSE nicholasSUSE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot remove already released charts.

If I remove them here, it will break my CI.
The proper deprecation process is just not to update them anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicholasSUSE nicholasSUSE nicholasSUSE requested changes

@manuelbuil manuelbuil manuelbuil approved these changes

@thomasferrandiz thomasferrandiz thomasferrandiz approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mgfritch @manuelbuil @thomasferrandiz @nicholasSUSE