Add xlsx-validator to travis build matrix#520
Open
vindvaki wants to merge 2 commits intorandym:release-3.0.0from
Open
Add xlsx-validator to travis build matrix#520vindvaki wants to merge 2 commits intorandym:release-3.0.0from
vindvaki wants to merge 2 commits intorandym:release-3.0.0from
Conversation
18263b4 to
1c802d0
Compare
Author
|
Oh and I guess your travis also uses the config from this PR for the build |
Author
|
Turns out the validator does not catch any of the corruption errors of current master, which is a bummer. So the added value seems pretty marginal. |
Author
|
Actually, it catches
|
Author
Collaborator
|
@vindvaki This looks like a promising feature. If you’re still interested in getting this merged, please reopen this PR in https://github.com/caxlsx/caxlsx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As promised in #501 (comment)
This adds a run of xlsx-validator on the files generated by
examples/example.rbto the travis build matrix. You can see it in action on travis for my forkThese same steps can be used to run the validator locally as long as you have docker installed.