Fix crash on unsigned integer input to cucim.skimage.morphology.reconstruction
#967
+47
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grlee77
added
bug
grlee77
force-pushed
the
grelee/fix-morphology-reconstruction-bug
branch
from
ca39a5a to
c14eb25
Compare
Signed-off-by: Gregory R. Lee <[email protected]>
grlee77
force-pushed
the
grelee/fix-morphology-reconstruction-bug
branch
from
c14eb25 to
dbe8839
Compare
jakirkham
reviewed
Nov 18, 2025
Member
jakirkham
left a comment
jakirkham
left a comment
There was a problem hiding this comment.
Thanks Greg! 🙏
Generally this looks reasonable
Had a couple questions below
| # Rescale image intensity so that we can see dim features. | ||
| image = rescale_intensity(image, in_range=(50, 200)) | ||
|
|
||
| seed = cp.copy(image) |
Member
There was a problem hiding this comment.
seed could be confused with random number generator seed. Should we use a different name like image2 or similar?
Contributor
Author
There was a problem hiding this comment.
sure, updated as suggested
| mask = image | ||
|
|
||
| seed = seed.astype(unsigned_dtype) | ||
| filled = reconstruction(seed, mask, method="erosion") |
Member
There was a problem hiding this comment.
Maybe this could be image2_eroded?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #964
This
reconstructionfunction is a hybrid implementation that still relies on an inner Cythonreconstruction_loopfunction from upstream scikit-image. I found that upgrading the input as done here avoids the observed crash and gives output that matches the scikit-image one.