Skip to content

remove deprecated square, rectangle and cube (replaced by footprint_rectangle) #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 24, 2025
Merged

remove deprecated square, rectangle and cube (replaced by footprint_rectangle) #969

merged 2 commits into from
Nov 24, 2025

Conversation

@grlee77
Copy link
Contributor

@grlee77 grlee77 commented Nov 9, 2025

Removing a few functions that we missed doing the scheduled removal for during the 25.08 release.

@grlee77 grlee77 added this to the v25.12.00 milestone Nov 9, 2025
@grlee77 grlee77 added this to cucim Nov 9, 2025
@grlee77 grlee77 requested a review from a team as a code owner November 9, 2025 13:02
@grlee77 grlee77 added breaking Introduces a breaking change improvement Improves an existing functionality labels Nov 9, 2025
@copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 9, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@grlee77
Copy link
Contributor Author

grlee77 commented Nov 13, 2025

/ok to test 377d87e

@gigony gigony changed the base branch from main to release/25.12 November 18, 2025 19:15
jakirkham
jakirkham approved these changes Nov 18, 2025
View reviewed changes
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Greg! 🙏

LGTM

During the meeting earlier we discussed how to flag deprecated functions for removal earlier in the release timeline. This is tracked in issue: #974

@jakirkham
Copy link
Member

jakirkham commented Nov 18, 2025

/ok to test 93ee577

@grlee77
Copy link
Contributor Author

grlee77 commented Nov 24, 2025

/merge

@rapids-bot rapids-bot bot merged commit 2e3bc68 into rapidsai:release/25.12 Nov 24, 2025
81 of 121 checks passed
@github-project-automation github-project-automation bot moved this to Done in cucim Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakirkham jakirkham jakirkham approved these changes

Assignees

No one assigned

Labels

breaking Introduces a breaking change improvement Improves an existing functionality

Projects

cucim
Status: Done

Milestone

v25.12.00

Development

Successfully merging this pull request may close these issues.

2 participants

@grlee77 @jakirkham