Skip to content
This repository was archived by the owner on Jul 28, 2025. It is now read-only.

Conversation

@harrism
Copy link
Member

@harrism harrism commented Dec 8, 2022

Description

This PR is in progress (draft).

This is a modification of the CrossingsMultiply algorithm worked out by @harrism and @isVoid that avoids explicit collinearity checks and consistently treats points on the polygon boundary as outside. While CrossingsMultiply works by shooting an imaginary ray in the +X direction from the test point and computing the inequality that results in crossings, this modification tests against +X and -X rays simultaneously.

Currently failing one of the tests, need to investigate.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added the libcuspatial Relates to the cuSpatial C++ library label Dec 8, 2022
@harrism harrism added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 8, 2022
@harrism harrism closed this May 13, 2025
@harrism harrism deleted the fea-strict-pip-algorithm branch May 13, 2025 21:44
@harrism harrism restored the fea-strict-pip-algorithm branch May 13, 2025 21:44
@harrism harrism reopened this May 13, 2025
@copy-pr-bot
Copy link

copy-pr-bot bot commented May 13, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

improvement Improvement / enhancement to an existing function libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant