Skip to content

Test RAFT with CCCL mdspan #1430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bdice wants to merge 14 commits into from
Closed

Test RAFT with CCCL mdspan #1430

bdice wants to merge 14 commits into from

Conversation

@bdice
Copy link
Contributor

@bdice bdice commented Oct 14, 2025

@copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 14, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@bdice
Copy link
Contributor Author

bdice commented Oct 14, 2025

/ok to test

@bdice
Copy link
Contributor Author

bdice commented Oct 16, 2025

/ok to test

@bdice
Copy link
Contributor Author

bdice commented Oct 17, 2025 •
edited
Loading

The build errors here seem to stem from a bunch of places in the source code where the extents type is left as default (uint32_t) or defined incorrectly. The previous mdspan implementation was willing to implicitly convert something like raft::make_device_matrix_view<const int64_t, uint64_t> to raft::make_device_matrix_view<const int64_t, int64_t>, unsafely casting uint64 to int64 in the extents type. The CCCL mdspan does not allow that. I am iterating through build errors to ensure that we have extent types properly defined.

@bdice
Copy link
Contributor Author

bdice commented Dec 9, 2025

Replaced by #1605, which is now complete.

@bdice bdice closed this Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

DO NOT MERGE

Projects

Vector Search, ML, & Data Mining Release Board
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@bdice