Sshash module superkmer anno #497
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add PTHash submodule, create boilerplate code for DBGSSHash class, add it to test_dbg_helpers.
and list of contigs
…etagraph into sshash_module_superkmer_anno
Contributor
Author
|
Also see ratschlab/sshash#10 for related changes in sshash repo. |
Collaborator
|
As mentioned during a previous meeting, I think annotating based on monotigs (monochromatic contigs) makes more sense. I've started an implementation at #500. Are there any fixes from the sshash library used here that we should port over there? |
Contributor
Author
Collaborator
Yes, it's implemented from scratch. So I'll close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request to track merging of further changes from @mmarzett.