-
Notifications
You must be signed in to change notification settings - Fork 4
New Features #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alrus2797
wants to merge
7
commits into
ravnhq:alexander-main
Choose a base branch
from
alrus2797:alexander-main
base: alexander-main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
New Features #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Sidebar Component
- Main View
- Home View components
- Shelf
- Shelf Item (cards)
- Header
- hooks for data fetching
- Basic Routing (to enable nav links on sidebar)
Added: - hook & context for context menus - hook & context for library - hooks for modals
Author
|
New squashed commit 19e4671 added new features:
Staging deploy here. |
Added:
- Library context and hooks
- Modal hooks
- Improvements on routing structure
- Auth control
Author
- Removed useEffect from search input -Removed useMemo from useAuth - Lifted useEffect from useLibrary to avoid multiple library requests
Author
|
New squashed commit 9180a96 includes these following changes:
|
- Removed throw on lifted logic from useLibrary - Update search results loading message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This is a squashed version of the PR #15
This PR contains:
Staging deploy here.