feat: expose zindex in toast #3035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8eba91c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
✅ PR title follows Conventional Commits specification. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8eba91c:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for custom z-index values in Toast components, allowing toasts to be positioned above or below other UI elements with specific z-index requirements.
- Adds a
zIndexprop toToastPropstype definition - Implements dynamic container z-index calculation based on custom toast z-index values
- Maintains relative stacking order where newer toasts appear above older ones
- Includes comprehensive Storybook examples demonstrating toast positioning above modals
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/blade/src/components/Toast/types.ts | Adds optional zIndex property to ToastProps type |
| packages/blade/src/components/Toast/ToastContainer.web.tsx | Implements z-index calculation logic for container and individual toast wrappers |
| packages/blade/src/components/Toast/Toast.stories.tsx | Adds ZIndex story demonstrating custom z-index usage with modal overlay examples |
| .changeset/kind-mayflies-fetch.md | Documents the feature addition as a minor version bump |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tewarig
requested review from
anuraghazra,
chaitanyadeorukhkar,
kamleshchandnani,
ravikumar-rajagopalan,
saurabhdaware and
swapnil-kr1
as code owners
Collaborator
🛡️ Coverage ReportSummaryFull Coverage Details |
swapnil-kr1
previously approved these changes
Dec 4, 2025
anuraghazra
reviewed
Dec 4, 2025
| * Custom z-index value for the toast container. | ||
| * This is useful when you want to position toasts above other elements like modals. | ||
| * | ||
| * @default 2000 |
Member
There was a problem hiding this comment.
default zIndex should be more than Modal.
In the TOAST_Z_INDEX also add 1 liner
// Because more than modal
const TOAST_Z_INDEX = 2001;
anuraghazra
previously approved these changes
Dec 4, 2025
anuraghazra
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
Additional Information
Component Checklist