network::if::static: Add VLAN capability #87
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds missing VLAN capability to network::if::static.
The existing documentation for using VLAN:s on static interfaces says to
instantiate network::global with the parameter vlan set to yes, such as:
class{'network::global':
vlan => 'yes'
}
This isn't sufficient. ifcfg-$ifname requires also the parameter
'VLAN=yes' defined, for a VLAN interface.
With this approach, that parameter is explicitly defined to
network::static::if, such as:
'network::static::if' { 'eth0.330':
ensure => 'up',
vlan => true,
ipaddress => '10.2.3.248',
netmask => '255.255.255.0',
}
This makes it abundandly clear what's going on.
Owner
|
@Millnert Thank you for your submission. As per the DEVELOP.md file, could you please resubmit from the |
Owner
|
Similar to #57. |
matschundbrei
pushed a commit
to matschundbrei/puppet-network
that referenced
this pull request
Nov 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing VLAN capability to network::if::static.
The existing documentation for using VLAN:s on static interfaces says to
instantiate network::global with the parameter vlan set to yes, such as:
class{'network::global':
vlan => 'yes'
}
This isn't sufficient. ifcfg-$ifname requires also the parameter
'VLAN=yes' defined, for a VLAN interface.
With this approach, that parameter is explicitly defined to
network::static::if, such as:
This makes it abundantly clear what's going on.