-
-
Notifications
You must be signed in to change notification settings - Fork 331
Fix SSR components rendering under CSR components #1324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shawncrawley
wants to merge
2
commits into
reactive-python:main
Choose a base branch
from
shawncrawley:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+58
−1
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| import React from "https://esm.sh/[email protected]" | ||
| import ReactDOM from "https://esm.sh/[email protected]/client" | ||
| import {Container} from "https://esm.sh/[email protected]/[email protected],[email protected],[email protected]&exports=Container"; | ||
| export {Container}; | ||
|
|
||
| export function bind(node, config) { | ||
| const root = ReactDOM.createRoot(node); | ||
| return { | ||
| create: (type, props, children) => | ||
| React.createElement(type, props, children), | ||
| render: (element) => root.render(element, node), | ||
| unmount: () => root.unmount() | ||
| }; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| import React from "https://esm.sh/[email protected]" | ||
| import ReactDOM from "https://esm.sh/[email protected]/client" | ||
| import {Container} from "https://esm.sh/[email protected]/[email protected],[email protected],[email protected]&exports=Container"; | ||
| export {Container}; | ||
|
|
||
| export function bind(node, config) { | ||
| const root = ReactDOM.createRoot(node); | ||
| return { | ||
| create: (type, props, children) => | ||
| React.createElement(type, props, children), | ||
| render: (element) => root.render(element, node), | ||
| unmount: () => root.unmount() | ||
| }; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -563,3 +563,32 @@ async def test_module_without_bind(display: DisplayFixture): | |
| "#my-generic-component", state="attached" | ||
| ) | ||
| assert await element.inner_text() == "Hello World" | ||
|
|
||
| async def test_nest_custom_component_under_web_component(display: DisplayFixture): | ||
| """ | ||
| Fix https://github.com/reactive-python/reactpy/discussions/1323 | ||
|
|
||
| Custom components (i.e those wrapped in the component decorator) were not able to | ||
| be nested under web components. | ||
|
|
||
| """ | ||
| module = reactpy.reactjs.file_to_module( | ||
| "nest-custom-under-web", JS_FIXTURES_DIR / "nest-custom-under-web.js" | ||
| ) | ||
| Container = reactpy.reactjs.module_to_vdom(module, "Container") | ||
|
Comment on lines
+575
to
+578
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should use the new |
||
|
|
||
| @reactpy.component | ||
| def CustomComponent(): | ||
| return reactpy.html.div( | ||
| reactpy.html.h1({"id": "my-header"}, "Header 1") | ||
| ) | ||
| await display.show( | ||
| lambda: Container( | ||
| CustomComponent() | ||
| ) | ||
| ) | ||
|
|
||
| element = await display.page.wait_for_selector( | ||
| "#my-header", state="attached" | ||
| ) | ||
| assert await element.inner_text() == "Header 1" | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate file?