fix: pipes in tables #1205
Merged
fix: pipes in tables #1205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
kellyjosephprice
requested review from
a team,
davinhazard,
rafegoldberg and
trishaprile
erunion
approved these changes
Oct 8, 2025
rafegoldberg
pushed a commit
that referenced
this pull request
Oct 8, 2025
|
This PR was released!🚀 Changes included in v11.2.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Fixes a regression in our markdown editor that would not properly escape pipes (
|) in tables.This allows users to write pipe characters directly in tables without them being interpreted as column separators. Normally, I would put this kind of convenience directly in the editor code. However, the logic to compile a table to gfm or jsx is in this library, and we want the escpaing to happen after the jsx conversion. That way we're not erronously escaping jsx tables.
🧬 QA & Testing