fix: migrating escaped html #1218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellyjosephprice
requested review from
a team,
ashacs,
erunion and
t-tullis
and removed request for
a team
erunion
reviewed
Nov 13, 2025
Member
There was a problem hiding this comment.
Is it worth also adding a test for when something that has the escaped already in an html block?
[block:html]
{
"html": "{`\n<pre>\n <code>\n RegexpExtract([Address], "\\\\s*([a-zA-Z]+)", 2)\n </code>\n</pre>`}"
}
[/block]
wondering if having double of this would bust it up:
{`{`
erunion
approved these changes
Nov 13, 2025
rafegoldberg
pushed a commit
that referenced
this pull request
Nov 13, 2025
## Version 11.7.4 ### 🛠 Fixes & Updates * migrating escaped html ([#1218](#1218)) ([c2461e0](c2461e0)), closes [/github.com//pull/1218/files#diff-6ee34c9f6ef36e20e57970ea252f6c7fdb016cf85f195e8c5212981b1c161586R42-R52](https://github.com/readmeio//github.com/readmeio/markdown/pull/1218/files/issues/diff-6ee34c9f6ef36e20e57970ea252f6c7fdb016cf85f195e8c5212981b1c161586R42-R52) <!--SKIP CI-->
Contributor
|
This PR was released!🚀 Changes included in v11.7.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Fixes how the migration was unescaping backslashes.
I believe the issue has to do with the how the latest version of remark handles escaping. AFAICT the easiest fix is it manually add back backslashes to the html strings.
🧬 QA & Testing
See tests