fix: frozen owlmoji #966
Closed
fix: frozen owlmoji #966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafegoldberg
approved these changes
Sep 12, 2024
Comment on lines
+45
to
+48
| const attributes = toAttributes( | ||
| { ...image.data.hProperties, ...('url' in image && { src: image.url }) }, | ||
| imageAttrs, | ||
| ); |
There was a problem hiding this comment.
Ahhh, interesting 🤔 this is a subtle refactor! So just ask to clarify: because we were actually assigning this src in to the image itself, it broke things…somewhere further along in one of our processors' "thread"? That makes sense with your fix!
There was a problem hiding this comment.
This line is where it's erroring, something higher up in the chain is somehow freezing this prop??!?! What's annoying, is I can't seem to reproduce it local to this repo?
Just figured it out. slate uses immer and the emoji serializer is just copying all the slate node data into the mdast. I'll fix this in the main app.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Fix loading owlmoji's.
The
astappears to be frozen, but I'm not sure where that's happening. Theimagedoesn't strictly need thesrcon thehPropertiessincerehypewill add it later, so this should be fine still.🧬 QA & Testing
Not sure how to reproduce this yet.