fix(oclif): disable engine warning #1333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanadgupta
added
the
needs-backport-to-v9
kanadgupta
pushed a commit
that referenced
this pull request
Aug 28, 2025
## [10.5.1-next.1](v10.5.0...v10.5.1-next.1) (2025-08-28) ### Bug Fixes * **oclif:** disable engine warning ([#1333](#1333)) ([f731713](f731713)) [skip ci]
Member
Author
|
🎉 This PR is included in version 10.5.1-next.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
kanadgupta
pushed a commit
that referenced
this pull request
Sep 8, 2025
Member
Author
|
🎉 This PR is included in version 10.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
as first discovered in #1331,
@oclif/coreuses its own node engine requirements and emits a warning if its node version requirements aren't met:they require v18 or later but we require v20 or later, so the warning looks like this (which is wrong):
due to this being misleading, we're going to disable this warning entirely. i don't think we need to emit warnings for mismatched versions of node.js (since the warning is already emitted when users install this CLI via
npm) but i'm open to reevaluating that.🧬 QA & Testing
confirmed that using a version of node.js less than 18 no longer emits this warning.