fix(openapi/upload): handle funky URLs #1344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanadgupta
added
bug
kanadgupta
deleted the
kanad-2025-09-16/handle-URLs-with-query-params
branch
kanadgupta
pushed a commit
that referenced
this pull request
Sep 17, 2025
## [10.5.2-next.1](v10.5.1...v10.5.2-next.1) (2025-09-17) ### Bug Fixes * **openapi/upload:** handle funky URLs ([#1344](#1344)) ([9a827ab](9a827ab)) [skip ci]
Member
Author
|
🎉 This PR is included in version 10.5.2-next.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Member
Author
|
🎉 This PR is included in version 10.5.2 🎉 The release is available on: (Note: Kanad wrote this by hand this because the |
kanadgupta
added a commit
that referenced
this pull request
Oct 8, 2025
| 🚥 Resolves CX-1793 | | :------------------- | ## 🧰 Changes expanding on the work from #1344, this PR tweaks a bunch of logic / DX improvements to better account for the following `rdme openapi upload` edge cases: - URL uploads that lack a path but have a custom slug with a JSON file extension (e.g., `rdme openapi upload https://example.com --custom-slug.json`) will now properly read that file and set that slug - URL uploads that lack a path but have a custom slug with a YAML file extension (e.g., `rdme openapi upload https://example.com --custom-slug.yml`) will now properly read that file and set that slug - URL uploads that lack a path and there's no `--slug` passed (e.g., `rdme openapi upload https://example.com`) will now default to `openapi.json` and emit a warning about this behavior - URL uploads with a path that lacks a file extension and there's no `--slug` passed (e.g., `rdme openapi upload https://example.com/some-path`) will now properly handle JSON/YAML and set the slug to that path (e.g., `some-path.json`). [applicable for both creates and updates] ## 🧬 QA & Testing honestly the more test cases i added, the more rework i realized this logic required 😮💨 the fact that they're passing brings me a lot of comfort here lol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
fixes a few issues where URLs with no path (e.g.,
https://example.com) or URLs with query params (e.g.,https://example.com/openapi?something=true) weren't being handled properly.🧬 QA & Testing
do tests pass?