Skip to content

Conversation

@malayparida2000
Copy link
Contributor

@malayparida2000 malayparida2000 commented Nov 11, 2025

In 4.16 when we implemented this change we had assumed the base to be 6 OSDs, but since than we have added a lot more pods to the ODF deployment.
The ODF docs also mention the resource requirement to be based on 3 OSDs
Ref-https://issues.redhat.com/browse/DFBUGS-4484

In 4.16 when we implemented this change we had assumed the base
to be 6 OSDs, but since than we have added a lot more pods to the
ODF deployment.
The ODF docs also mention the resource requirement to be based on 3 OSDs

Signed-off-by: Malay Kumar Parida <[email protected]>
@malayparida2000
Copy link
Contributor Author

/cherry-pick release-4.20
/cherry-pick release-4.19

@openshift-cherrypick-robot

@malayparida2000: once the present PR merges, I will cherry-pick it on top of release-4.19, release-4.20 in new PRs and assign them to you.

In response to this:

/cherry-pick release-4.20
/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@malayparida2000
Copy link
Contributor Author

/cc @SanjalKatiyar

@openshift-ci openshift-ci bot requested a review from SanjalKatiyar November 11, 2025 08:53
Copy link
Contributor

@bipuladh bipuladh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, malayparida2000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit e8b3d37 into red-hat-storage:master Nov 21, 2025
7 checks passed
@openshift-cherrypick-robot

@malayparida2000: new pull request created: #2393

In response to this:

/cherry-pick release-4.20
/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@malayparida2000: new pull request created: #2394

In response to this:

/cherry-pick release-4.20
/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@malayparida2000
Copy link
Contributor Author

/cherry-pick release-4.18
/cherry-pick release-4.17
/cherry-pick release-4.16
/cherry-pick release-4.15

@openshift-cherrypick-robot

@malayparida2000: #2385 failed to apply on top of branch "release-4.15":

Applying: Change the resource requirement base calculation from 6 to 3 OSDs
Using index info to reconstruct a base tree...
M	packages/odf/components/create-storage-system/create-storage-system-steps/capacity-and-nodes-step/configure-performance.spec.tsx
M	packages/odf/utils/ocs.ts
Falling back to patching base and 3-way merge...
Auto-merging packages/odf/utils/ocs.ts
CONFLICT (content): Merge conflict in packages/odf/utils/ocs.ts
Auto-merging packages/odf/components/create-storage-system/create-storage-system-steps/capacity-and-nodes-step/configure-performance.spec.tsx
CONFLICT (content): Merge conflict in packages/odf/components/create-storage-system/create-storage-system-steps/capacity-and-nodes-step/configure-performance.spec.tsx
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Change the resource requirement base calculation from 6 to 3 OSDs

In response to this:

/cherry-pick release-4.18
/cherry-pick release-4.17
/cherry-pick release-4.16
/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@malayparida2000
Copy link
Contributor Author

/cherry-pick release-4.18

@openshift-cherrypick-robot

@malayparida2000: new pull request created: #2395

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@malayparida2000
Copy link
Contributor Author

/cherry-pick release-4.17

@malayparida2000
Copy link
Contributor Author

/cherry-pick release-4.16

@openshift-cherrypick-robot

@malayparida2000: new pull request created: #2396

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@malayparida2000: new pull request created: #2397

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@malayparida2000
Copy link
Contributor Author

/cherry-pick release-4.20-compatibility
/cherry-pick release-4.19-compatibility
/cherry-pick release-4.18-compatibility
/cherry-pick release-4.17-compatibility
/cherry-pick release-4.16-compatibility

@openshift-cherrypick-robot

@malayparida2000: new pull request created: #2413

In response to this:

/cherry-pick release-4.20-compatibility
/cherry-pick release-4.19-compatibility
/cherry-pick release-4.18-compatibility
/cherry-pick release-4.17-compatibility
/cherry-pick release-4.16-compatibility

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@malayparida2000: new pull request created: #2414

In response to this:

/cherry-pick release-4.20-compatibility
/cherry-pick release-4.19-compatibility
/cherry-pick release-4.18-compatibility
/cherry-pick release-4.17-compatibility
/cherry-pick release-4.16-compatibility

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@malayparida2000: new pull request created: #2415

In response to this:

/cherry-pick release-4.20-compatibility
/cherry-pick release-4.19-compatibility
/cherry-pick release-4.18-compatibility
/cherry-pick release-4.17-compatibility
/cherry-pick release-4.16-compatibility

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@malayparida2000: new pull request created: #2416

In response to this:

/cherry-pick release-4.20-compatibility
/cherry-pick release-4.19-compatibility
/cherry-pick release-4.18-compatibility
/cherry-pick release-4.17-compatibility
/cherry-pick release-4.16-compatibility

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@malayparida2000: cannot checkout release-4.20-compatibility: error checking out "release-4.20-compatibility": exit status 1 error: pathspec 'release-4.20-compatibility' did not match any file(s) known to git

In response to this:

/cherry-pick release-4.20-compatibility
/cherry-pick release-4.19-compatibility
/cherry-pick release-4.18-compatibility
/cherry-pick release-4.17-compatibility
/cherry-pick release-4.16-compatibility

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants