Skip to content
This repository was archived by the owner on Sep 18, 2018. It is now read-only.

Conversation

@manishapme
Copy link
Contributor

@manishapme manishapme commented Aug 30, 2018

There's only 19 rows in postgres for the allow_live_update key and it hasn't been written to in a year. Think it's safe to deprecate.

@manishapme manishapme requested a review from spladug September 4, 2018 22:32
Copy link
Contributor

@spladug spladug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an anti-evil safeguard that predates the is_hidden_discussion checks added much later below. It's intended to allow an employee to remove links from the sidebar on livethreads because they're abusive/trolly. If you're going to remove this option, which is fine because contributors have their own more flexible powers now, it'd be good to make sure the existing hidden threads are moved over to the new system so people viewing old live threads don't see the nasty stuff that was deliberately hidden.

pedantic nit: deleting the attribute is removing it. deprecation is when it's still around but you're saying "please don't use it for new stuff"

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants