Add marked text support in Markdown#87
Open
TheRealVira wants to merge 4 commits intoreddit:masterfrom
Open
Conversation
sp3nx0r
added a commit
that referenced
this pull request
Oct 19, 2021
* Add case insensitive SipHash implementation * Replace ref hash function with SipHash * Add label to link_ref struct. * Update find_link_ref to compare link labels as well as hashes * Update add_link_ref to disallow duplicate entries. * cast to char from uint8_t for strncasecmp * update README markdown, remove TODO * add py2 wheel generation * fix: add logic for older glibc not having getrandom, impacting staging Co-authored-by: Nicolaas <[email protected]>
sp3nx0r
added a commit
that referenced
this pull request
Oct 20, 2021
* Add case insensitive SipHash implementation * Replace ref hash function with SipHash * Add label to link_ref struct. * Update find_link_ref to compare link labels as well as hashes * Update add_link_ref to disallow duplicate entries. * cast to char from uint8_t for strncasecmp * update README markdown, remove TODO * add py2 wheel generation * fix: add logic for older glibc not having getrandom, impacting staging Co-authored-by: Nicolaas <[email protected]>
Contributor
Author
|
Hey @sp3nx0r I have seen your commit, but am a bit confused now. Is my PR still compatible? Do you need anything from me to merge it? |
Contributor
Author
|
💇♀️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User could use this as the following:
Which then would get translated to:
Similar to my previous PR (#86) this might be a need feature to bring some color in text and it would help to make some highlighting (aside from using the underline function). My implementation should support inline text highlighting, but please check it for errors as I am a bit rusty with my C skills.
If you need anything else, please let me know! I am not sure if this is still active, but it's worth a try I guess 😄
This feature is widely used on other platforms too: